Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1788231: pkg/cmd/render: improve IPv6 support #52

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Bug 1788231: pkg/cmd/render: improve IPv6 support #52

merged 1 commit into from
Feb 12, 2020

Conversation

hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Jan 4, 2020 •
edited
Loading

Second iteration of IPv6 support includes a refactor of render and improved unit tests.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 4, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2020
@hexfusion hexfusion changed the title WIP Ipv6 v2 pkg/cmd/render: improve IPv6 support Feb 1, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 1, 2020
danwinship
danwinship reviewed Feb 3, 2020
View reviewed changes
pkg/cmd/render/render.go Show resolved Hide resolved
pkg/cmd/render/render.go Outdated Show resolved Hide resolved
@danwinship
Copy link
Contributor

This is currently totally blocking IPv6-on-4.4 testing so it would be good to get it in soon even if it's not perfect yet.
/retest

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 5, 2020
@hexfusion
Copy link
Contributor Author

/hold

this still needs testing

@hexfusion
Copy link
Contributor Author

But as dan noted it is blocking

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2020
@hexfusion hexfusion force-pushed the ipv6_v2 branch 2 times, most recently from d51d8f9 to 94e80a1 Compare February 6, 2020 00:56
@hexfusion hexfusion changed the title pkg/cmd/render: improve IPv6 support Bug 1788231: pkg/cmd/render: improve IPv6 support Feb 6, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 6, 2020
@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1788231, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1788231: pkg/cmd/render: improve IPv6 support

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1788231, which is valid.

In response to this:

Bug 1788231: pkg/cmd/render: improve IPv6 support

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2020
@hexfusion
Copy link
Contributor Author

/retest

@hexfusion
Copy link
Contributor Author

/test e2e-aws

using payload for manual testing

@danwinship
Copy link
Contributor

What needs to be done to get this to merge? If parts of it are not ready, is it possible to split out just the "make IPv6 work" part without any of the refactoring and get that merged? This is currently blocking us from being able to have IPv6 CI on 4.4. (It's not the only thing blocking that, or else @eparis would be standing over your shoulder asking "are we there yet?" over and over until you merged, but it will soon be the only bug that we know of that blocks IPv6 CI.)

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2020
@hexfusion
Copy link
Contributor Author

What needs to be done to get this to merge? If parts of it are not ready, is it possible to split out just the "make IPv6 work" part without any of the refactoring and get that merged? This is currently blocking us from being able to have IPv6 CI on 4.4. (It's not the only thing blocking that, or else @eparis would be standing over your shoulder asking "are we there yet?" over and over until you merged, but it will soon be the only bug that we know of that blocks IPv6 CI.)

point taken :), will resolve today.

@hexfusion
pkg/cmd/render: refactor
d48fcf6 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2020
@deads2k
Copy link
Contributor

deads2k commented Feb 11, 2020

I doubt this works in a week.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hexfusion
Copy link
Contributor Author

/retest

@hexfusion
Copy link
Contributor Author

@danwinship this solves some but not all the problems. we need this anyway so consider this a down payment.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8f4c3ae into openshift:master Feb 12, 2020
@openshift-ci-robot
Copy link

@hexfusion: All pull requests linked via external trackers have merged. Bugzilla bug 1788231 has been moved to the MODIFIED state.

In response to this:

Bug 1788231: pkg/cmd/render: improve IPv6 support

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@hexfusion: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure d48fcf6 link /test e2e-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@danwinship danwinship mentioned this pull request Feb 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship danwinship left review comments

@deads2k deads2k deads2k left review comments

@alaypatel07 alaypatel07 Awaiting requested review from alaypatel07

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hexfusion @danwinship @openshift-ci-robot @deads2k @openshift-bot @openshift-merge-robot